feat:新增blufi配网协议 #1321
Open
feat:新增blufi配网协议 #1321
+1,011
−330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
建议使用 network_provisioning，维护性会更好一些。 |
Author
|
感谢您的建议，这是一个很棒的优化，我将进行重构 |
|
请问现在这个blufi配网协议已经优化过了嘛？为啥还不合并到主干捏 |
Author
我已经完成了优化，将blufi写到了一个class中，避免混乱。并且我注意到由network_provisioning提供的蓝牙配网协议与blufi似乎不同。因此我重新实现了一个class而非使用network_provisioning |
Owner
|
CMakeLists.txt 的改动会不会太大了，另外需要提供一个文档来说明用法。可以放在 docs 下。 |
Author
很抱歉我的自动格式化程序将CMakeLists.txt进行了格式化，我将避免格式化程序引入的改动。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#546
简单新增了blufi协议，支持通过官方app或其他使用esp-blufi协议的app进行配网操作。