Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: OCI registry when releasing helm chart #105

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix: OCI registry when releasing helm chart #105

merged 1 commit into from
Jul 12, 2024

Conversation

albertollamaso
Copy link
Contributor

@albertollamaso albertollamaso commented Jul 12, 2024 •
edited
Loading

Installation of helm chart use this path in the OCI registry: oci://8gears.container-registry.com/library/n8n but with latest release it is required to add an extra path /n8n

When trying:

helm pull oci://8gears.container-registry.com/library/n8n --version 0.24.0
Error: 8gears.container-registry.com/library/n8n:0.24.0: not found

it works when

helm pull oci://8gears.container-registry.com/library/n8n/n8n --version 0.24.0

But that's not the path used in the helm chart documentation. CF: https://artifacthub.io/packages/helm/open-8gears/n8n/

You can also confirm that latest release 0.24.0 is not available in the helm chart. CF: https://artifacthub.io/packages/helm/open-8gears/n8n/?modal=changelog

Summary by CodeRabbit

  • Chores
    • Updated Helm chart push configuration to a new location within the container registry.

@albertollamaso
Fix: OCI registry when releasing helm chart
4f0b11b 
Inbstallation of helm chart use this path in the OCI registry: `oci://8gears.container-registry.com/library/n8n` but with latest release it is required to add an extra path `/n8n`

When trying:
```
helm pull oci://8gears.container-registry.com/library/n8n --version 0.24.0
Error: 8gears.container-registry.com/library/n8n:0.24.0: not found
```

it works when
```
helm pull oci://8gears.container-registry.com/library/n8n/n8n --version 0.24.0
```

But that's not the path used in the helm chart documentation.
CF: https://artifacthub.io/packages/helm/open-8gears/n8n/

You can also confirm that latest release `0.24.0` is not available in the helm chart.
CF: https://artifacthub.io/packages/helm/open-8gears/n8n/?modal=changelog
@albertollamaso albertollamaso requested a review from a team as a code owner July 12, 2024 05:41
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 12, 2024 •
edited
Loading

Walkthrough

The change modifies the Helm push command in the GitHub Actions workflow for pushing Helm charts. By removing the specific chart name n8n from the destination path, the updated command pushes the Helm chart to a more general location within the container registry, which could potentially address issues related to package location and directory structure.

Changes

File Change Summary
.github/workflows/push.yaml Modified the helm push command to remove the chart name n8n from the destination path.

Sequence Diagram(s)

The changes do not include new features or significant modifications to the control flow, so no sequence diagrams are provided.

Possibly related issues

Poem

In the land of Helm charts, a tweak so grand,
The path was changed, by careful hand.
No more names to tie it down,
Now it soars to new renown.
Pushed with ease, to the registry's heart,
A smoother flow, a brand new start.
🐰✨🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 12, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e812630 and 4f0b11b.

Files selected for processing (1)
  • .github/workflows/push.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/push.yaml

@albertollamaso albertollamaso mentioned this pull request Jul 12, 2024
Closed
@Vad1mo Vad1mo merged commit 640ce87 into 8gears:main Jul 12, 2024
2 checks passed
@Vad1mo
Copy link
Member

Vad1mo commented Jul 12, 2024

@albertollamaso thank you, for correcting that typo.

@Vad1mo
Copy link
Member

Vad1mo commented Jul 12, 2024

new release is out

@albertollamaso
Copy link
Contributor Author

Thanks @Vad1mo for quick action on this. I am now able to pull the release version 0.24.0 using the proper OCI ur.
Perhaps it is not showing in the UI: https://artifacthub.io/packages/helm/open-8gears/n8n/?modal=changelog
Not sure if an extra step is required in artifacthub.io to be honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai coderabbitai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertollamaso @Vad1mo