specify resource path for ecs credential url #1228
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1229
Problem
According to the AWS Documentation it is expected that the
AWS_CONTAINER_CREDENTIALS_FULL_URI
env var contains theget-credentials
path for example:http://localhost/get-credentials
.We use aws vault exclusively for our AWS access at highwing.io and it works flawlessly when connecting with the SDK or using short-term credentials in a subshell like
aws-vault exec account
and the--server
works fine when using the cli, using vscode AWS Toolkit, etc.When using the Ruby SDK, the ECS credential server is not being picked up by default, even though the
AWS_CONTAINER_CREDENTIALS_FULL_URI
is supported by the Ruby SDK (see the:endpoint
option).The ECS credentials are picked up if we override the existing env var:
and the
get-credentials
route does not seem to break the cli:Suggested Change
I added the
get-credentials
path to the server address.This change would prevent a bit of ceremony I need to manage on my side when using the Ruby SDK for localhost development, I'd really appreciate if you would consider the change.
Caution I don't know Go
I ran the tests and had 3 failures before and after the change.
I rake the make task and it failed to build because I don't have a local signing cert (I think).
I'm happy to make any changes to the PR to meet the process of the project, or if its easier, please feel free to take this contribution and run with it. Thanks for such a great tool and I hope this helps adoption!