Conversation
Open
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관 이슈
📝 요약
🙏 리뷰 요청사항
✅ PR 유형
다음과 같은 변경 사항이 있습니다.
변경사항 상세
Member 엔티티 (Member.java)
제거된 필드
password, createdAt·updatedAt·inactiveDate — 로그인·회원가입, 비활성화 기능에 쓰이던 필드 전부삭제
ENUM 필드 이름 변경 및 기본값 조정
컬럼명 memberType → member_type (@column(name="member_type"))
허용값은 USER, RECORDER, ADMIN 세 가지만 남기고, 기본값 default 'USER' 로 설정
-관계 필드 직렬화 처리
casts·comments 컬렉션에 @JsonIgnore
###DB 스키마 마이그레이션
-컬럼 삭제/이름 변경
ALTER TABLE member DROP COLUMN member_type;
ALTER TABLE member CHANGE COLUMN memberType member_type
ENUM('USER','RECORDER','ADMIN') NOT NULL DEFAULT 'USER';
기존 값 정리
UPDATE member
SET memberType = 'USER'
WHERE memberType IN ('ELDER','GENERAL');
-ChangeMemberTypeRequest
사용자 스스로 USER ↔ RECORDER 전환 요청 바디용 (@NotNull MemberType memberType)
##MemberService 리팩토링 (MemberService.java)
-불필요 메서드 삭제
MemberController 리팩토링 (MemberController.java)
-엔드포인트 축소
-DTO 반환
##Repository 정리 (MemberRepository.java)
삭제: findByEmail, existsByEmail
유지: 닉네임 중복 검사용 existsByNickname (필요 없으면 빈 인터페이스로 두셔도 무방)