-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor/#36 모듈 의존성 정리 #57
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9e3e2b2
refactor: swagger 의존성 설정
minjo-on a31a9c7
refactor: jts 의존성 수정
minjo-on d68c779
refactor: db 의존성 수정
minjo-on 1146548
refactor: repository 분리
minjo-on d42538b
refactor: security, jpa 의존성 분리
minjo-on f19593c
refactor: spring 관련 의존성 분리
minjo-on File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
soridam-domain/src/main/java/sorisoop/soridam/domain/noise/domain/NoiseRepository.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package sorisoop.soridam.domain.noise.domain; | ||
|
||
import java.util.List; | ||
import java.util.Optional; | ||
|
||
import org.locationtech.jts.geom.Point; | ||
|
||
public interface NoiseRepository { | ||
List<Noise> getNearbyNoises(Point point); | ||
|
||
List<Noise> findByAvgDecibleAndPoint(Point point, Radius radius, NoiseLevel noiseLevel); | ||
|
||
Optional<Noise> findById(String id); | ||
|
||
Noise save(Noise noise); | ||
|
||
boolean existsById(String id); | ||
|
||
void deleteById(String id); | ||
} |
50 changes: 50 additions & 0 deletions
50
...omain/src/main/java/sorisoop/soridam/domain/noise/infrastructure/NoiseRepositoryImpl.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package sorisoop.soridam.domain.noise.infrastructure; | ||
|
||
import java.util.List; | ||
import java.util.Optional; | ||
|
||
import org.locationtech.jts.geom.Point; | ||
import org.springframework.stereotype.Repository; | ||
|
||
import lombok.RequiredArgsConstructor; | ||
import sorisoop.soridam.domain.noise.domain.Noise; | ||
import sorisoop.soridam.domain.noise.domain.NoiseLevel; | ||
import sorisoop.soridam.domain.noise.domain.NoiseRepository; | ||
import sorisoop.soridam.domain.noise.domain.Radius; | ||
|
||
@Repository | ||
@RequiredArgsConstructor | ||
public class NoiseRepositoryImpl implements NoiseRepository { | ||
private final JpaNoiseRepository jpaNoiseRepository; | ||
private final QueryNoiseRepository queryNoiseRepository; | ||
|
||
@Override | ||
public List<Noise> getNearbyNoises(Point point) { | ||
return queryNoiseRepository.getNearbyNoises(point); | ||
} | ||
|
||
@Override | ||
public List<Noise> findByAvgDecibleAndPoint(Point point, Radius radius, NoiseLevel noiseLevel) { | ||
return queryNoiseRepository.findByAvgDecibleAndPoint(point, radius, noiseLevel); | ||
} | ||
|
||
@Override | ||
public Optional<Noise> findById(String id) { | ||
return jpaNoiseRepository.findById(id); | ||
} | ||
|
||
@Override | ||
public Noise save(Noise noise) { | ||
return jpaNoiseRepository.save(noise); | ||
} | ||
|
||
@Override | ||
public boolean existsById(String id) { | ||
return jpaNoiseRepository.existsById(id); | ||
} | ||
|
||
@Override | ||
public void deleteById(String id) { | ||
jpaNoiseRepository.deleteById(id); | ||
} | ||
} |
13 changes: 13 additions & 0 deletions
13
soridam-domain/src/main/java/sorisoop/soridam/domain/user/domain/UserRepository.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package sorisoop.soridam.domain.user.domain; | ||
|
||
import java.util.Optional; | ||
|
||
import sorisoop.soridam.common.domain.Provider; | ||
|
||
public interface UserRepository { | ||
User save(User user); | ||
|
||
Optional<User> findByEmail(String email); | ||
|
||
Optional<User> findByOauthIdentityAndProvider(String oauthIdentifier, Provider provider); | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleteNoise 메서드의 ID 처리가 불완전합니다.
ID 접두사(prefix) 처리가 누락되었습니다.
getNoise
메서드와 동일하게NOISE.getPrefix()
를 사용해야 합니다.📝 Committable suggestion