Speed up client cam using Set #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABCxFF
approved these changes
Jul 10, 2023
|
err i thought about closing this tbh. Benchmarks dont really seem that useful. Sometimes its way faster sometimes not, depends on factors i dont know which is why i didnt merge it yet. If u feel like testing this more throughly feel free :) |
|
I feel like whatever is better for readability and maintainability should be prioritized |
|
I suppose using Sets is a good idea then 🤔 but its my code so ig im biased lmao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all.
Confirm the following: