Skip to content

Comments

improve docker, quay#6

Open
bwalsh wants to merge 1 commit intodevelopmentfrom
feature/improve-quay
Open

improve docker, quay#6
bwalsh wants to merge 1 commit intodevelopmentfrom
feature/improve-quay

Conversation

@bwalsh
Copy link
Collaborator

@bwalsh bwalsh commented Oct 16, 2024

This PR:

  • simplifies docker file
  • adds git hash to image

@bwalsh
Copy link
Collaborator Author

bwalsh commented Oct 16, 2024

I tested this locally by adding this to Secrets/values.yaml

image-viewer:
  serviceName: image-viewer-service
  image:
    repository: quay.io/ohsu-comp-bio/gen3-image-viewer
    pullPolicy: Always
    tag: "feature_improve-quay"

@matthewpeterkort
Copy link
Collaborator

matthewpeterkort commented Oct 16, 2024

tested and running on cbds-dev LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewpeterkort matthewpeterkort matthewpeterkort approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bwalsh @matthewpeterkort