Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document (using ACE in Molly) update #43

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

YangshuaiWang
Copy link

I have identified an opportunity for enhancement in the document. In this particular instance, no output was generated. Consequently, I initiated the simulation, conducted a simple temperature analysis, and subsequently exported the trajectory to both a .xyz file and a .gif format. Should time permit and a consensus be reached, I intend to incorporate additional examples and analysis functions (static, thermodynamics, ...) to further augment the document's content.

@tjjarvinen
Copy link
Collaborator

Thanks for the initiative.

I would like to have few changes to be made.

  1. The main point with ACEmd is to replace JuLIP with a newer AtomsBase compatible framework. So, I would like for you to replace JuLIP with AtomsIO in examples.
  2. Also you could add that Ovito is one example program, VMD and PyMol few others.
  3. Molly also has functionality to generate visualizations when GlMakie has been loaded that could be very useful to add too (look for Molly docs and example use in Molly basics).

I have not yet added Molly v0.18 to the support list. But will do it soon, that should fix some issues with AtomsBase compatibility...

@YangshuaiWang
Copy link
Author

Thanks for the comments, I will change the first one and add the second one accordingly, as for the third one, I think the visualization in Molly is a bit ugly (just my personal preference), but yes, maybe you're right, just adding it is not bad at all.

@tjjarvinen
Copy link
Collaborator

Yep we can mention that the Molly visualization is there. And I do agree that it is not up to what Ovito, MD, etc. are.

@YangshuaiWang
Copy link
Author

Hi,

According to your suggestion, I am trying to replace JuLIP with AtomsIO, but I get stuck, I try to run:
fname_xyz = joinpath(pkgdir(ACEmd), "data", "TiAl-big.xyz")
data = ExtXYZ.Atoms(read_frame(fname_xyz))
sys = Molly.System(data, pot)
save_system("test.xyz", sys)
but I got this:

julia> ERROR: MethodError: no method matching element(::Missing)

Any comment for this? I try to read the document of AtomsIO, but unfortunately it is not friendly enough to be read.

My package status is:

[69e0c927] ACEmd v0.1.5
[3b96b61c] ACEpotentials v0.6.3
[1692102d] AtomsIO v0.2.2
[352459e4] ExtXYZ v0.1.12
[945c410c] JuLIP v0.14.3
⌃ [aa0f7f06] Molly v0.17.0
[91a5bcdd] Plots v1.39.0
[1986cc42] Unitful v1.17.0

@tjjarvinen
Copy link
Collaborator

This seems to be a bug in Molly (or several of them) related to AtomsBase support.

Probably the best way forward is for me to make a PR(s) for Molly to fix these issues.

I hopefully have time for that later this week...

@YangshuaiWang
Copy link
Author

YangshuaiWang commented Sep 14, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants