Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base weapon recoil generation change+ small bugfix + hybrid trace changes #3

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

LeninCat
Copy link
Contributor

-Removed intense screenshake from aimpunch produced by high latency
-Added client initiated muzzle climb recoil
-Fixed recoil and aimpunch being applied while sprinting

-Removed intense screenshake from aimpunch produced by high latency
-Added client initiated muzzle climb recoil
-Fixed recoil and aimpunch being applied while sprinting
Copy link
Member

@LiddulBOFH LiddulBOFH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to still keep Ply as a localized version of the player, calling self.Owner repeatedly is not good for performance due to the extremely inefficient metatable index entities have, and self:GetOwner() is preferred over self.Owner
"IFTP" is also not needed as it is only being used once, not to mention its being defined in the global space when it should be localized
"ang" should also be localized

requested changes to base weapon code from pr requested has been applied
@LeninCat
Copy link
Contributor Author

LeninCat commented Sep 30, 2024

changes have been applied

missed a line
-Hybrid trace now only initiates when hitting Player or NPC
-Added selectable effect to hybrid trace. BloodImpact and ACF_Penetration.
-linterhell (a.)
@LeninCat LeninCat changed the title base weapon recoil generation change+ small bugfix base weapon recoil generation change+ small bugfix + hybrid trace changes Oct 2, 2024
@LeninCat
Copy link
Contributor Author

LeninCat commented Oct 2, 2024

-hybrid trace changes added (effects added)
-linterhell

@LeninCat LeninCat requested a review from LiddulBOFH October 22, 2024 18:46
@LeninCat
Copy link
Contributor Author

any update on merge?

@LiddulBOFH
Copy link
Member

Sorry, it's been a hot minute since I've really sat down to do things. For the most part it looks good, just one of those micro optimizations, that IFTP variable still bugs me particularly when its defined and used a single time like that, given how conditionals work it'd be better in this case to call the function where it's needed instead of setting it in memory and then reading it. I'll merge and make a few other changes before updating workshop.

@LiddulBOFH LiddulBOFH merged commit 92a5ec9 into ACF-Team:main Jan 13, 2025
1 check passed
@LeninCat
Copy link
Contributor Author

Thanks for the merge, as for the IFTP i had to keep it the way it is to prevent the eye angle recoil from continuously applying more than intended when the player has more ping than like 20. There might be another way to not use this method to prevent the eye angle creep but i don't know how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants