Dev #509
Open
Dev #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ammo crate size is now defined by the arrangement of projectiles rather than external dimensions - Ammo is now hexagonally packed - Current ammo is displayed inside crates
ACF HEAT was changed to do [10x](326fe66) when spalling was added to kinetics, because spalling did not work on chemical rounds. However, chemical rounds (e.g. missiles) can be used to slug (remove health) considerably better than kinetic projectiles. This was not the intention. This should rectify things.
- Simplified the code dramatically. Instead of reusing the same entity over and over, we'll just spawn and remove one for each unique model. - Changed the dimension calculation to use GetModelBounds: Available and consistent in both realms. Addressed issues with some missiles AABB only containing the missile body and not the fins - Optimized volume calculations
- Added support for custom models in ammo crates - Fixed some scaling issues
This reverts commit 9a86656.
They just make helicopter bomb models.
Why did they ever do this thats not how tracers work
- Removed "Refill" ammo type - Added "Supply" crate under components tab: Refills fuel and ammo - Added sphere and cylinder shapes to fuel (cylinder replaces drum) - Created acf_container baseclass to generalize behavior of ACFs container types - Fixed stale mass updates: Mass update timers set the mass to the current content * unitmass instead of the mass when the timer was fired
This reverts commit 0c5785f. This change introduces some weird race-condition-esque issue where previous scalable entities have completely wrong meshes (I was seeing entirely different entities getting entirely different models in some cases)
No longer need to manually specify FOV <3
This reverts commit 0eb5644.
RACs previously had their limits reduced from 16 to 2 due to server performance and balance concerns, alongside other automatic weapons. HE was added to RACs due to request and to see whether it could be properly balanced given the new limits. It has become apparent that HE on RACs is the worst offender of what is a problematic HE model. There have also been complaints about RACs losing their niche of high rate of fire, which is a valid point. Reverting the RAC ROF to 2000 and removing HE is an acceptable compromise to deal with both of these issues.
Outside callers like Physical Parent can call ents.Create("acf_class"), which doesn't call one of our constructors that sets self.ACF
GetMesh/GetMeshConvexes is about 2.5x slower than our ModelData.GetMesh functionality Replaced the dumb random pos calculation for spherical objects
Avoids overhead from creating new timers every tick (also stop polluting fprofiler) Cleaned up legal checks
Mirrors serverside behavior: aborts if not valid
Check for "Active" value change was broken. Only became apparently when using Wirelink, as standard wire IO only triggers when the value changes (doing this for us). Wirelinks trigger every time they're called.
This code can't be ripped out entirely. Some things now rely on ACF.PlayersInContraptionIterator. (See: aircraft baseplates.) We can look into a less annoying way to implement this, more than likely checking if the weapon can do damage to others, which would require a player being in the contraption. This would be a good inbetween of too strict for testing vs. restricting handhelds/autonomous weapons/remote control weapons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entities:
QOL/Code Quality:
Mechanics:
Bug Fixes: