Rotate taproot swap-in addresses #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pm47
force-pushed
the
taproot-rotate-pm
branch
from
e8640e4
to
8c2197c
Compare
pm47
commented
Jan 18, 2024
src/commonMain/kotlin/fr/acinq/lightning/blockchain/electrum/SwapInWallet.kt
Outdated
Show resolved
Hide resolved
sstone
force-pushed
the
snapshot/swap-in-potentiam-taproot
branch
3 times, most recently
from
2f2b29c
to
d22dfd1
Compare
pm47
force-pushed
the
taproot-rotate-pm
branch
from
8c2197c
to
1c17d26
Compare
sstone
reviewed
Jan 25, 2024
src/commonMain/kotlin/fr/acinq/lightning/blockchain/electrum/ElectrumMiniWallet.kt
Outdated
Show resolved
Hide resolved
sstone
force-pushed
the
snapshot/swap-in-potentiam-taproot
branch
2 times, most recently
from
8fa7fea
to
c865b24
Compare
pm47
force-pushed
the
taproot-rotate-pm
branch
from
16af706
to
5c4cbcb
Compare
sstone
force-pushed
the
snapshot/swap-in-potentiam-taproot
branch
from
91ea457
to
361faa9
Compare
sstone
reviewed
Jan 30, 2024
src/commonMain/kotlin/fr/acinq/lightning/blockchain/electrum/ElectrumMiniWallet.kt
Outdated
Show resolved
Hide resolved
src/commonTest/kotlin/fr/acinq/lightning/blockchain/electrum/ElectrumMiniWalletTest.kt
Outdated
Show resolved
Hide resolved
|
LGTM! There is yet no limit on the number of address that can be generated (it could be set explicitly in the wallet, or implicitly by the generator which could return |
pm47
force-pushed
the
taproot-rotate-pm
branch
2 times, most recently
from
6387515
to
6eba0f8
Compare
sstone
force-pushed
the
snapshot/swap-in-potentiam-taproot
branch
from
02d89fb
to
962efbb
Compare
pm47
force-pushed
the
taproot-rotate-pm
branch
from
7bd0e8a
to
42ec19c
Compare
sstone
force-pushed
the
snapshot/swap-in-potentiam-taproot
branch
3 times, most recently
from
ecbc4c6
to
f963c21
Compare
sstone
force-pushed
the
snapshot/swap-in-potentiam-taproot
branch
3 times, most recently
from
5e18d0b
to
7d17663
Compare
pm47
force-pushed
the
taproot-rotate-pm
branch
from
7ea242e
to
57ee3a4
Compare
Base automatically changed from
snapshot/swap-in-potentiam-taproot
to
master
February 15, 2024 09:22
pm47
force-pushed
the
taproot-rotate-pm
branch
from
57ee3a4
to
38e3e97
Compare
|
Rebased on master. |
sstone
reviewed
Feb 15, 2024
src/commonMain/kotlin/fr/acinq/lightning/blockchain/electrum/ElectrumMiniWallet.kt
Outdated
Show resolved
Hide resolved
I think that it's better than worrying about unintentional address reuse, and it will be regulated by increasingly slow sync times anyway. |
This meta notably contains the index if the address was deterministically generated.
We create and monitor a fixed number of different swap-in addresses. Peer will choose an empty swap-in addresses if there is one, or a random address if there are none. We limit the number of monitored swap-in addresses to avoid hitting resource limits on Electrum servers. A few hundred addresses (100 or 200) is a safe limit.
We keep the core logic for watching individual addresses, and just generate more when needed.
It's not really synchronous, but we rely the least possible on the mailbox. This makes the `window` disappear because we are scanning addresses one by one. Suggested by @sstone.
It's more consistent with Utxo and makes jvm interop easier.
pm47
force-pushed
the
taproot-rotate-pm
branch
from
38e3e97
to
82c0d22
Compare
sstone
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses groundwork made in branch swap-in-potentiam-taproot-rotate, but replaces hardcoded addresses by proper unbounded rotation.
Some cleanup is done at the end, by extracting wallets outside of
Peer.Best reviewed commit-by-commit.