Refactor watcher types #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watch types (and mostly the `BitcoinEvent` sealed class) were confusing because we imported code from `eclair` and never adapted it to mobile wallets where we have less complex watch scenarios. We refactor this and rename the different kind of events to match what we're using. This is a first step towards doing exhaustive pattern matching when a watch triggers, which we'll do in the next commit. We also add a few helper variables and move funding helpers.
We can now use exhaustive pattern matching when a watch triggers, which is particularly important in the `Closing` state where we want to make sure we're not missing any scenario.
pm47
approved these changes
Feb 12, 2025
sstone
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watch types (and mostly the
BitcoinEventsealed class) were confusing because we imported code fromeclairand never adapted it to mobile wallets where we have less complex watch scenarios.We refactor this and rename the different kind of events to match what we're using. We can thus use exhaustive pattern matching when a watch triggers, which is particularly important in the
Closingstate where we want to make sure we're not missing any scenario.