Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitcoin-kmp 0.22.1 and secp256k1-kmp 0.17.1 #762

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

sstone
Copy link
Member

@sstone sstone commented Feb 13, 2025

These versions target kotlin 2.1.10 and are compatible with java 1.8.

@sstone sstone marked this pull request as ready for review February 13, 2025 15:14
@sstone sstone requested a review from dpad85 February 13, 2025 15:14
@sstone
Copy link
Member Author

sstone commented Feb 13, 2025

Can also be rebased and merged on master once #757 has been merged.

Base automatically changed from kotlin-2.1.10 to master February 14, 2025 09:00
@pm47
Copy link
Member

pm47 commented Feb 14, 2025

Needs rebase

@sstone sstone force-pushed the kotlin-2.1.10-update-bitcoin-kmp branch from 21f9313 to 9bf95f6 Compare February 14, 2025 09:22
@sstone
Copy link
Member Author

sstone commented Feb 14, 2025

Rebased on ea8193e

dpad85
dpad85 previously approved these changes Feb 14, 2025
Copy link
Member

@dpad85 dpad85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS and Android, along with ktor3.

@pm47 pm47 force-pushed the kotlin-2.1.10-update-bitcoin-kmp branch from 9bf95f6 to 7b987d8 Compare February 14, 2025 14:46
@pm47
Copy link
Member

pm47 commented Feb 14, 2025

Rebased

@pm47 pm47 requested a review from dpad85 February 14, 2025 15:16
@pm47 pm47 merged commit 47987a4 into master Feb 14, 2025
2 checks passed
@pm47 pm47 deleted the kotlin-2.1.10-update-bitcoin-kmp branch February 14, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants