Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create TellerAccess entity and add unit tests #38

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

yvanhenang
Copy link
Contributor

feat: Create TellerAccess entity and add unit tests

  • Implemented the TellerAccess entity with attributes: id, name, tellerId, status, dailyLimit, createdDate, lastModifiedDate, and accessType
  • Defined the enum AccessStatus to manage status transitions (ACTIVE, SUSPENDED)
  • Added JPA annotations for entity mapping and database persistence
  • Developed unit tests to verify object creation, status updates, daily limit modifications, and date handling
  • Set up JUnit 5 for testing

This commit establishes the TellerAccess entity with full functionality and ensures its behavior is validated through unit tests.

@NkwaTambe
Copy link
Contributor

NkwaTambe commented Oct 2, 2024

Good job @yvanhenang

please look through your code again and ticket description..

you can reconsider refactoring your code if you want.

and please fix your test (The failing PMD check)

@nancymuyeh nancymuyeh linked an issue Oct 3, 2024 that may be closed by this pull request
Copy link
Contributor

@Elwizzy12 Elwizzy12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pmd check failing too , check the violations and try resolve, always ensure that your pmd check passes locally before pushing.

@nancymuyeh nancymuyeh self-requested a review October 7, 2024 15:50
@yvanhenang yvanhenang merged commit d594355 into develop Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define Entity TellerAccess
6 participants