-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Update topofileformats dependency to AFMReader [URGENT] #851
Comments
Two tests fail on switching...
Branch is I'll see if I can cross reference to tests in AFMReader tomorrow and work out what the correct values should be. |
First frame of the test asd file with its kde of heights First frame of my See that the images are visually the same but the heights are scaled differently. @ns-rse I personally think that this shows that the new code is good to overwrite the test checksums? |
Thanks @SylviaWhittle Happy to go with your conclusion. Would be useful to work out what the difference here is, perhaps |
I've a virtualenv with I can see a few changes but am not sure these would have the magnitude of effect. Where
|
As detailed in #851 the sum of the arrays changes on switching from `topofileformats` > `AFMReader`. The issue notes some details of investigation.
As detailed in #851 the sum of the arrays changes on switching from `topofileformats` > `AFMReader`. The issue notes some details of investigation.
Checklist
topostats process --core 1
.topostats --version
Describe the bug
Change the
topofileformats
dependency toAFMReader
as it's currently broken.Copy of the output
NA
Include the configuration file
NA
To Reproduce
NA
TopoStats Version
2.1.2
Python Version
3.11
Operating System
GNU/Linux
Python Packages
NA
The text was updated successfully, but these errors were encountered: