-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update dependency to AFMReader #852
Conversation
With renaming `topofileformats` > `AFMReader` and removing the former from PyPI we had to update the dependency. Currently two tests fail... ``` FAILED tests/test_io.py::test_load_scan_asd - assert -1368044348.3393068 == -71724923530211.84 FAILED tests/test_io.py::test_load_scan_get_data[load_scan_asd-197-image_shape5--673381139990.2344-file_122-2.0] - assert -12843725.967220962 == -673381139990.2344 ```
As detailed in #851 the sum of the arrays changes on switching from `topofileformats` > `AFMReader`. The issue notes some details of investigation.
ed7f46c
to
389fb10
Compare
Looks good and clean - Thanks for the update to the docs too Neil Seems to work for the asd file we've been given, and the classic minicircles spm. A few comments though:
|
Thanks for having a look @MaxGamill-Sheffield I'm going to avoid scope creep and keep this PR focused on switching |
…l_channels add orig err msg in broad channel try/except
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Closes #851
With renaming
topofileformats
>AFMReader
and removing the former from PyPI we had to update the dependency.As detailed in #851 the sum of the arrays changes on switching from
topofileformats
>AFMReader
. The issue notes some details of investigation.Also took the opportunity to update the installation instructions to make it clearer and include information on installing from GitHub using
pip
.