Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pre-commit hooks recommended by Scientific Python #767

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

ns-rse
Copy link
Collaborator

@ns-rse ns-rse commented Dec 19, 2023

More work on #721 adding additional
recommended pre-commit hooks

Closes #734
Closes #736
Closes #765
Closes #766

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d107dd8) 84.25% compared to head (3adbc6c) 84.25%.
Report is 1 commits behind head on main.

Files Patch % Lines
topostats/io.py 66.66% 1 Missing ⚠️
topostats/processing.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #767   +/-   ##
=======================================
  Coverage   84.25%   84.25%           
=======================================
  Files          21       21           
  Lines        3105     3105           
=======================================
  Hits         2616     2616           
  Misses        489      489           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ns-rse ns-rse force-pushed the ns-rse/scientific-python-pre-commit branch from fa6dc4c to f7efd0e Compare December 19, 2023 20:34
Spellchecks code files but ignores changes via .git-blame-ignore-revs
@ns-rse ns-rse force-pushed the ns-rse/scientific-python-pre-commit branch from f7efd0e to 3adbc6c Compare December 19, 2023 20:42
@ns-rse ns-rse merged commit 67e298b into main Dec 19, 2023
12 of 13 checks passed
@ns-rse ns-rse deleted the ns-rse/scientific-python-pre-commit branch December 19, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant