Rendering #1
Rendering #1
Conversation
bdi_game/src/render/sdl.rs
Outdated
|
|
||
| /// SDL unit | ||
| pub struct UnitSDL<'a> { | ||
| pub position: &'a (i32, i32), |
There was a problem hiding this comment.
Do we really need a reference to 2 4-byte numbers? :D
There was a problem hiding this comment.
[NOT OUTDATED] It's not about memory it's about having reference to existing object so if we update it's location then the rendering will also be updated. My pipeline caches objects to be rendered and it is workaround to make updates easier. But there are still issues with it:
- What happens when original entity is destroyed? Because of explicit lifetimes all clusters using this object are destroyed -> in the case when compiler don't find issue, we have runtime error
- Also i32? If we want to pass screen's coordinates and not game's coordinates then it's meaningless because screen can have only positive numbers in SDL -> we need to decide where translation to the correct coordinates happens
bdi_game/src/render/traits.rs
Outdated
| type Unit<'a>; | ||
| type Render<'a>: Render<Unit<'a> = Self::Unit<'a>>; | ||
|
|
||
| /// Creates Renderer. |
There was a problem hiding this comment.
[NOT OUTDATED] Comments must be updated -> i will link to the resolving commit (should it happen :D )
bdi_game/src/render/sdl.rs
Outdated
| pub struct UnitSDL<'a> { | ||
| pub position: &'a (i32, i32), | ||
| pub texture: Option<&'a sdl2::render::Texture<'a>>, | ||
| pub color: Option<sdl2::pixels::Color>, |
There was a problem hiding this comment.
Why do we need this? As an alternative to texture?
There was a problem hiding this comment.
For the record i will write here my point that i made during our talk:
Yes, because it's fallback for us to make sure we aren't forced to use textures when we don't need to.
There was a problem hiding this comment.
I forgot how powerful are enums in rust, it will be swapped to the enum -> I will link the resolving commit here.
|
Create render_map() <- to render hexagons |
| @@ -6,7 +6,7 @@ edition = "2021" | |||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
|
|
|||
| [dependencies] | |||
| sdl2 = { version = "0.36.0", features = ["bundled"]} | |||
| sdl2 = { version = "0.36.0", features = ["bundled", "gfx", "image"]} | |||
There was a problem hiding this comment.
Te nowe biblioteki mogą wymagać gfx i image na systemie, tak? Może w takim razie przydałoby się jakieś info w README?
bdi_game/src/game/game.rs
Outdated
| input::Input, | ||
| simulation::{simulation::Simulation, world_state::WorldState}, | ||
| }; | ||
|
|
||
| use super::logging::init_logging; | ||
|
|
||
| pub struct Game<D: GameDisplay> { | ||
| display: D, |
There was a problem hiding this comment.
Please don't, this trait here is for a reason
There was a problem hiding this comment.
It was quick fix to make sure examples are compiling because we had name clash with my/your display mod. I'll resolve it
…rom traits to structures.
…nder example, created "how to" use examples
…indow creation in example is working
…provide library yourself), created boilerplate hexagon drawing
…s), updated example
Creating draft to discuss rendering development here.