Actions #4
Merged
Actions #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stabor705
requested changes
Apr 2, 2024
bdi_game/src/display/actions.rs
Outdated
| } | ||
|
|
||
| impl Action { | ||
| pub fn check_click_grid_cell(x: i32, y: i32) -> Option<Self> { |
There was a problem hiding this comment.
I would go with something like from_click
There was a problem hiding this comment.
changed it to from_left_click in case we want to use right mouse button later.
bdi_game/src/display/actions.rs
Outdated
|
|
||
| fn match_input(sdl_ev: Event) -> Option<Action> { | ||
| match sdl_ev { | ||
| Event::KeyDown { keycode, .. } => Self::match_key_down(keycode.unwrap()), |
There was a problem hiding this comment.
Avoid .unwrap() at all cost :P
There was a problem hiding this comment.
added if keycode.is_some() match guard so it always works
There was a problem hiding this comment.
try if Event::KeyDown { Some(keycode), .. } works
There was a problem hiding this comment.
nope, i get error, keycode itself is of type Option, so there is no point in wrapping it in Some()
vLesio
reviewed
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented basic system for managing in-game actions and sdl events.