Skip to content

Better save message for async checkpoint saving#1122

Merged
copybara-service[bot] merged 1 commit intomainfrom
mattdavidow-better-save-message
Dec 27, 2024
Merged

Better save message for async checkpoint saving#1122
copybara-service[bot] merged 1 commit intomainfrom
mattdavidow-better-save-message

Conversation

@gobbleturk
Copy link
Collaborator

@gobbleturk gobbleturk commented Dec 23, 2024

Description

Add a more accurate logging message for saving a checkpoint with an async checkpointer
Before: saved a checkpoint at step {step}
After: Started an asynchronous checkpoint save for step {step}

Tests

  • Ran with an async checkpointer, saw expected message
  • Ran with a sync checkpointer, saw expected message

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

@gobbleturk gobbleturk force-pushed the mattdavidow-better-save-message branch from 98aec8d to faa7eaa Compare December 23, 2024 18:49
@copybara-service copybara-service bot merged commit ca43b4f into main Dec 27, 2024
@copybara-service copybara-service bot deleted the mattdavidow-better-save-message branch December 27, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants