Pylint for forks, some condition as unit tests #1129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies the pylint check conditions to be the same as for the unit tests. Previously forks (such as PRs from external contributors), would skip the pylint check, thus some code could be submitted that does not pass our pylint and had to be fixed after being submitted. This should fix this case - now the pylint will run on these PRs and block submit, giving the PR author a nice message run "bash code_style.sh" to fix pylint.
Previously: Only for branch pushes, any branch
Proposed: For any pull request and only pushes to main branch
Tests
This is how we we currently run our unit tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):