Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint for forks, some condition as unit tests #1129

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

gobbleturk
Copy link
Collaborator

@gobbleturk gobbleturk commented Dec 26, 2024

Description

Modifies the pylint check conditions to be the same as for the unit tests. Previously forks (such as PRs from external contributors), would skip the pylint check, thus some code could be submitted that does not pass our pylint and had to be fixed after being submitted. This should fix this case - now the pylint will run on these PRs and block submit, giving the PR author a nice message run "bash code_style.sh" to fix pylint.

Previously: Only for branch pushes, any branch
Proposed: For any pull request and only pushes to main branch

Tests

This is how we we currently run our unit tests

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed.

Copy link
Collaborator

@vipannalla vipannalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@copybara-service copybara-service bot merged commit 4699f4f into main Dec 27, 2024
19 checks passed
@copybara-service copybara-service bot deleted the mattdavidow-pylint-for-all branch December 27, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants