Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for installing nightly version oftensorboard_plugin_profile #194

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Add support for installing nightly version oftensorboard_plugin_profile #194

merged 6 commits into from
Oct 4, 2023

Conversation

shahyash10
Copy link
Contributor

@shahyash10 shahyash10 commented Oct 3, 2023 •
edited
Loading

Helpful for ensuring that a profile collected with nightlies work with tbp-nightly

@shahyash10 shahyash10 requested a review from rwitten as a code owner October 3, 2023 00:18
@shahyash10 shahyash10 changed the title Add support for installing tensorboard_plugin_profile Add support for installing nightly version oftensorboard_plugin_profile Oct 3, 2023
bvandermoon
bvandermoon reviewed Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@bvandermoon bvandermoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally ok with this change. But just wondering if there is a need for it? For example, is it helpful for your workflow? Is it true that JAX nightly users also want tbp-nightly?

@shahyash10
Copy link
Contributor Author

I'm generally ok with this change. But just wondering if there is a need for it? For example, is it helpful for your workflow? Is it true that JAX nightly users also want tbp-nightly?

It is helpful for the nightly XLML tests and ensures that a profile collected with nightly version of JAX works with nightly version of tbp

@bvandermoon
Copy link
Collaborator

I'm generally ok with this change. But just wondering if there is a need for it? For example, is it helpful for your workflow? Is it true that JAX nightly users also want tbp-nightly?

It is helpful for the nightly XLML tests and ensures that a profile collected with nightly version of JAX works with nightly version of tbp

Got it, makes sense. Thanks Yash. Please add that to the description for context

rwitten
rwitten requested changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@rwitten rwitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should uninstall ahead of time like we do for Jax/Jaxlib. That way we can change.

@shahyash10 shahyash10 requested a review from rwitten October 4, 2023 17:52
rwitten
rwitten requested changes Oct 4, 2023
View reviewed changes
setup.sh Outdated Show resolved Hide resolved
@shahyash10 shahyash10 merged commit 8a4b417 into main Oct 4, 2023
@shahyash10 shahyash10 deleted the tbp_nightly branch October 4, 2023 20:30
A9isha pushed a commit that referenced this pull request Apr 11, 2024
@raymondzouu
Add metric collection to maxtext convergence test (#194)
8dc028b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvandermoon bvandermoon bvandermoon approved these changes

@rwitten rwitten rwitten approved these changes

@khatwanimohit khatwanimohit Awaiting requested review from khatwanimohit khatwanimohit is a code owner

Assignees

@rwitten rwitten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahyash10 @bvandermoon @rwitten