Run maxtext with XPK doc #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obliviour
reviewed
Oct 4, 2023
khatwanimohit
force-pushed
the
mohit/xpk_doc
branch
from
7055c05 to
737a851
Compare
Obliviour
approved these changes
Oct 4, 2023
rwitten
requested changes
Oct 4, 2023
xpk/Run_MaxText.md
Outdated
|
|
||
| ``` | ||
| # Default will pick stable versions of dependencies | ||
| cd maxtext |
xpk/Run_MaxText.md
Outdated
| limitations under the License. | ||
| --> | ||
|
|
||
| # How to run MaxText with XPK ? |
There was a problem hiding this comment.
Nit: there should be no space between "XPK" and "?"
| gcloud config set compute/zone $ZONE | ||
|
|
||
| # Make sure you are in the maxtext github root directory when running this command | ||
|
|
There was a problem hiding this comment.
Can you think about how to bridge this for a new user. Perhaps we should link to the XPK README at the top and say we assume you understand the XPK basics.
khatwanimohit
force-pushed
the
mohit/xpk_doc
branch
from
737a851 to
171bf00
Compare
khatwanimohit
force-pushed
the
mohit/xpk_doc
branch
from
171bf00 to
951a834
Compare
rwitten
approved these changes
Oct 6, 2023
A9isha
pushed a commit
that referenced
this pull request
Apr 11, 2024
* Migrate MXLA tests form GCE to GKE. Pause all MXLA tests on GCE. * resolve comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.