Fix vllm weight mapping import issue. #2629
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavclemson
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
hengtaoguo,
jiangjy1982,
khatwanimohit,
richjames0,
shralex,
suexu1025 and
vipannalla
as code owners
abhinavclemson
force-pushed
the
adaptor-fix
branch
from
28cce39 to
1bed9fa
Compare
bvandermoon
approved these changes
Nov 7, 2025
| import re | ||
|
|
||
| import maxtext.src.maxtext.integration.tunix.weight_mapping as weight_mapping # pylint: disable=consider-using-from-import | ||
| from MaxText.integration.tunix.weight_mapping import StandaloneVllmWeightMapping |
Collaborator
There was a problem hiding this comment.
Do you know why this happened with copybara?
Collaborator
There was a problem hiding this comment.
@abhinavclemson you would need to update the copybara script otherwise this PR will not be useful
Also there are other places where this is broken, so other files need to be added to the copybara
https://github.com/AI-Hypercomputer/maxtext/compare/anisha-fix-trainrl?expand=1
khatwanimohit
approved these changes
Nov 7, 2025
hengtaoguo
approved these changes
Nov 7, 2025
Collaborator
hengtaoguo
left a comment
hengtaoguo
left a comment
There was a problem hiding this comment.
Interesting, this is not caught by copybara?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix vllm weight mapping import issue.
FIXES: b/458679845
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.