Skip to content

Conversation

@SurbhiJainUSC
Copy link
Collaborator

Description

  • Fix import for llama_or_mistral_ckpt
  • Fix base output directory for Gemma2 and Gemma3 E2E tests

FIXES: b/447464486

Tests

python3 src/MaxText/utils/ckpt_scripts/llama_mistral_mixtral_orbax_to_hf.py src/MaxText/configs/base.yml base_output_directory=$OUTPUT_PATH load_parameters_path=$MODEL_CKPT_PATH run_name=llama_ckpt model_name=llama2-7b hardware=tpu hf_model_path=/tmp/llama2-7b

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

@RissyRan
Copy link
Collaborator

RissyRan commented Nov 7, 2025

Thanks for the fix! Let's consolidate path into #2635?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants