Letting users pass args via M_* #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwitten
force-pushed
the
rwitten_add_env_vars
branch
from
09757be to
ba7d6ff
Compare
rwitten
changed the title
raymondzouu
reviewed
Jan 12, 2024
MaxText/pyconfig.py
Outdated
| @@ -61,9 +65,17 @@ def _lists_to_tuples(l: list[Any]) -> Union[tuple[Any],list[Any]]: | |||
|
|
|||
| class _HyperParameters(): | |||
| # pylint: disable=missing-class-docstring | |||
| def _validate_env_variables(self, raw_data_from_yaml): | |||
| for environment_var in os.environ: | |||
| if environment_var[:4] == _MAX_PREFIX: | |||
There was a problem hiding this comment.
I think this is supposed to be environment_var[:2] to check for "M_". Could also change it to environment_var[:len(_MAX_PREFIX)] in case the prefix is changed.
There was a problem hiding this comment.
yes thank you Raymond, fixed on new revision. I changed the name late. Nice eagle eyes calling out both the unnecessary constant and the wrong constant!
(p.s. -- I woke up at midnight because I dreamt of this bug. amazing that you had already caught it when I woke up!)
rwitten
force-pushed
the
rwitten_add_env_vars
branch
from
ba7d6ff to
633847b
Compare
rwitten
force-pushed
the
rwitten_add_env_vars
branch
from
633847b to
18d2469
Compare
gobbleturk
approved these changes
Jan 12, 2024
raymondzouu
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can pass args via setting an env var M_ARG_NAME.