Add llama2 configs for GPU A3 #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwitten
requested changes
Apr 5, 2024
MaxText/configs/a3/llama_2_7b/1vm.sh
Outdated
|
|
||
|
|
||
| # 1 node, DATA_DP=1, ICI_FSDP=8 | ||
| python3 xpk/xpk.py workload create --cluster ${CLUSTER_NAME} --workload ${WORKLOAD_NAME} \ |
There was a problem hiding this comment.
We don't put the XPK command inside of the script -- please match the style we use elsewhere.
There was a problem hiding this comment.
Also unless I'm missing something we coudl break this into separately 5 env files and 1 script?
There was a problem hiding this comment.
I believe we need 5 different env and configs.
yangyuwei
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Shall we update the --xla_dump_to=gs://runner-maxtext-logs/yooh/llama2-70b-$(date +%Y-%m-%d-%H-%M)/HLO_dumps/ to get rid of personal directory and change 70b to 7b?
There was a problem hiding this comment.
The same for MaxText/configs/a3/llama_2_7b/8vm.sh.
yangyuwei
approved these changes
Apr 5, 2024
michelle-yooh
force-pushed
the
yooh/gpu_llama_configs
branch
from
600eca9 to
1200dd7
Compare
rwitten
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.