Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subset of hosts dataloading for TPU v4 #586

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

khatwanimohit
Copy link
Collaborator

No description provided.

@khatwanimohit khatwanimohit force-pushed the mohit/subset_v4 branch 2 times, most recently from b9a5a4d to e94b3fc Compare April 11, 2024 01:39
Copy link
Collaborator

@rwitten rwitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like part of this CR is missing?

MaxText/input_pipeline/input_pipeline_interface.py Outdated Show resolved Hide resolved
@rwitten rwitten removed their assignment Apr 11, 2024
@khatwanimohit khatwanimohit requested a review from rwitten April 11, 2024 21:30
Copy link
Collaborator

@rwitten rwitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving approval but I have some important feedback

MaxText/train.py Outdated Show resolved Hide resolved
MaxText/input_pipeline/input_pipeline_interface.py Outdated Show resolved Hide resolved
MaxText/train.py Show resolved Hide resolved
@copybara-service copybara-service bot merged commit 6ec7556 into main Apr 19, 2024
8 checks passed
@copybara-service copybara-service bot deleted the mohit/subset_v4 branch April 19, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants