Run codespell using pre-commit
#602
Conversation
khatwanimohit
force-pushed
the
mohit/codespell
branch
4 times, most recently
from
25b8ff2 to
c679e20
Compare
khatwanimohit
force-pushed
the
mohit/codespell
branch
2 times, most recently
from
5217b86 to
38d285e
Compare
khatwanimohit
force-pushed
the
mohit/codespell
branch
from
38d285e to
ad072dd
Compare
| @@ -38,13 +38,12 @@ RUN mkdir -p /deps | |||
| # Set the working directory in the container | |||
| WORKDIR /deps | |||
|
|
|||
| # Copy necessary build files to docker container | |||
| COPY setup.sh requirements.txt constraints_gpu.txt /deps/ | |||
There was a problem hiding this comment.
This is done so that when we are making changes independent of dependencies, we won't do the installation step again, which can take >2m. Is there a specific concern to overrule it? @khatwanimohit
There was a problem hiding this comment.
setup.sh now includes running the pre-commit install command which installs the pre-commit hooks in the user's git repo. That command needs access to .pre-commit-config.yaml file
| @@ -195,7 +195,8 @@ fi | |||
| # Install dependencies from requirements.txt | |||
| cd $run_name_folder_path && pip install --upgrade pip | |||
| if [[ "$MODE" == "pinned" ]]; then | |||
| pip3 install -r requirements.txt -c constraints_gpu.txt | |||
There was a problem hiding this comment.
I think adding -U here goes against the idea of pinned build. Previously, the versions installed will be the function of the base image (which is pinned) and reqs and constraints. Now it could potentially be time-dependent if we happen to miss to capture the constraints in the constraints file. WDYT? @khatwanimohit
There was a problem hiding this comment.
I understand, we can remove it.
No description provided.