patching supervised loss weight because it is not passed to NeuralAdmixture class #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again,
Thanks again for answering to my issue.
I noticed that the
--supervised_loss_weight
parameter is available to modify the supervised loss weight. However, it doesn’t seem to propagate correctly into theNeuralAdmixture
class, the code always uses the default value of 100.I applied a small patch to fix this and confirmed that the parameter now behaves as expected on my dataset.
My commit is just a suggestion, please feel free to use or adapt it if you find it helpful.
Examples
In my dataset, when I'm using the pip installed version of neural-admixture (1.6.7) :
Each facet on the second plot I've show the Q matrix for the training dataset when varying the
--supervised_loss_weight
parameter but as you can see nothing change. On the top plot you can see the result with classic Admixture as a comparison.And with the patch I did:
Best regards,
Vincent Rocher