-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDM4hep as default output format and run on all events by default #1328
Comments
In mattermost you claimed there was a dependence on whether one uses the particle gun or not and that changes the output format, that is somewhat different from changing the default output format... but that can be considered.
It does not crash, it ends execution with a clear error message. The error returns immediately and is clear to understand and fix by the user. Instead running for potentially a long time by default sounds much worse to me. |
The edm4hep output from the gun was coming from an alias, sorry, changing the title. I also realize that this default behavior depends on how DD4hep is built. What are the flags used for the Key4hep build? I see from Spack:
which should have edm4hep as default output. About forcing users to provide the |
After checking, the request becomes: have edm4hep output format as default when DD4hep is compiled with both edm4hep and lcio flags ON. Opened a PR: #1329 |
When running with an inputfile, ddsim still outputs an lcio file as default:
outputs
dummyOutput.slcio
.Another thing that could be nice to improve is to run on all events of the provided input file by default (the expected behavior in most cases). Right now, not providing the
-N -1
crashes withThe text was updated successfully, but these errors were encountered: