Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDM4hep as default output format and run on all events by default #1328

Closed
BrieucF opened this issue Oct 10, 2024 · 3 comments · Fixed by #1329
Closed

EDM4hep as default output format and run on all events by default #1328

BrieucF opened this issue Oct 10, 2024 · 3 comments · Fixed by #1329

Comments

@BrieucF
Copy link
Contributor

BrieucF commented Oct 10, 2024

When running with an inputfile, ddsim still outputs an lcio file as default:

source /cvmfs/sw-nightlies.hsf.org/key4hep/setup.sh
ddsim --inputFiles /eos/experiment/fcc/users/b/brfranco/background_files/sr_photons_kevin/SR_photon_v3_fixed.hepevt --compactFile $K4GEO/FCCee/IDEA/compact/IDEA_o1_v03/IDEA_o1_v03.xml -N -1

outputs dummyOutput.slcio.

Another thing that could be nice to improve is to run on all events of the provided input file by default (the expected behavior in most cases). Right now, not providing the -N -1 crashes with

ERROR: Batch mode requested, but did not set number of events
@andresailer
Copy link
Member

In mattermost you claimed there was a dependence on whether one uses the particle gun or not and that changes the output format, that is somewhat different from changing the default output format... but that can be considered.

not providing the -N -1 crashes with

It does not crash, it ends execution with a clear error message. The error returns immediately and is clear to understand and fix by the user. Instead running for potentially a long time by default sounds much worse to me.

@BrieucF
Copy link
Contributor Author

BrieucF commented Oct 10, 2024

The edm4hep output from the gun was coming from an alias, sorry, changing the title. I also realize that this default behavior depends on how DD4hep is built. What are the flags used for the Key4hep build? I see from Spack:

    variant("lcio", default=False, description="Enable build with lcio")
    variant("edm4hep", default=True, description="Enable build with edm4hep")

which should have edm4hep as default output.

About forcing users to provide the -N arguments, it is a matter of taste, my preference would be to process the full file if nothing is specified but fine.

@BrieucF BrieucF changed the title EDM4hep as default output format in all cases and run on all events by default EDM4hep as default output format and run on all events by default Oct 10, 2024
@BrieucF
Copy link
Contributor Author

BrieucF commented Oct 11, 2024

After checking, the request becomes: have edm4hep output format as default when DD4hep is compiled with both edm4hep and lcio flags ON. Opened a PR: #1329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants