-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edm4hep format as default when both edm4hep and lcio enabled #1329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me. Just want someone from ILD to OK as well.
Will this actually yield EDM4hep files and not the DD4hep format without the @gaede anything speaking against this? I think all of the worklows, tutorials, etc. get an LCIO output in any case, because we specify an output file name with |
This PR does not change the behavior in case both the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
edm4hep
is ON, rootfiles will be edm4hep
Thanks for the clarification. I have either missed that entirely or forgotten again in the meatime.
All good from my side then.
Test Results 10 files 10 suites 4h 35m 15s ⏱️ For more details on these failures, see this check. Results for commit 985a4bb. |
I could not relate any of the failing test to this PR... |
BEGINRELEASENOTES
edm4hep
the default output format in case DD4hep is compiled with bothDDD4HEP_USE_LCIO
DD4HEP_USE_EDM4HEP
ONENDRELEASENOTES