Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::abs, ddsim logging of sensitive detectors #1196

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

andresailer
Copy link
Member

BEGINRELEASENOTES

  • NestedBoxReflection_geo.cpp: use std::abs instead of abs
  • HexGrid: use std::abs instead of abs
  • DDSim: better logging of which sensitive detector is used when defaults are used

ENDRELEASENOTES

@sebouh137
Could you confirm that the abs in HexGrid is the one for floats?
As we had an issue #1192, where the abs changed, it is better to use std::abs explicitly everywhere.

Copy link

github-actions bot commented Dec 7, 2023

Test Results

       6 files         6 suites   7h 16m 59s ⏱️
   356 tests    356 ✔️ 0 💤 0
1 058 runs  1 058 ✔️ 0 💤 0

Results for commit fbbbdef.

♻️ This comment has been updated with latest results.

@andresailer andresailer merged commit e0889e6 into AIDASoft:master Dec 14, 2023
14 checks passed
@andresailer andresailer deleted the fixFabs branch December 14, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant