-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a signal handler for SIGINT when building a detector #1300
Conversation
I am not a big friend of this PR. In general the rule is always:
In the event this behaviour is not wanted, users have to scan source code to find all signals handled internally.
|
Test Results 14 files 14 suites 5h 36m 36s ⏱️ Results for commit d99f75b. ♻️ This comment has been updated with latest results. |
Closing this PR in view of the changes from #1336. But we need to enable the signal handler in ddsim now, I think. |
@andresailer Yes. The handler would have to be enabled in ddsim. The test show which line to call:
|
To cancel while building a geometry it seems I have to kill the process or the terminal where it's running. With this change it's possible to cancel by doing a Ctrl-C, and it seems to be working both in Python and C++:
And then press Ctrl-C:
BEGINRELEASENOTES
ENDRELEASENOTES