Always use seqId in logEntryId #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #40 by always adding seqId at the end of the logEntryId, on which the URI for the corresponding RemoteExecution is based on.
If the timestamp is available, it is still used as part of logEntryId. But now seqId is added after the timestamp, avoiding the clash between different log entries happening in the same time slot.
Note that as the sequence id is computed on the whole input log, it does not restart for each different timestamp.
Another solution would be to use a counter for each different timestamp (restarting thus from 0 or 1), but this could represent a bottleneck during parallel execution.