Ally move filter #100
Merged
Ally move filter #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
trigaten
reviewed
Oct 21, 2022
trigaten
reviewed
Oct 21, 2022
trigaten
reviewed
Oct 21, 2022
trigaten
reviewed
Oct 21, 2022
| @@ -287,6 +290,102 @@ def generate_support_proposals(self, comms_obj: MessagesData) -> Dict[str, str]: | |||
| final_messages[recipient] = str(suggested_proposals) | |||
| comms_obj.add_message(recipient, str(suggested_proposals)) | |||
| return final_messages | |||
|
|
|||
| def is_order_aggressive_to_powers(self, order: str, powers: List[str]): | |||
There was a problem hiding this comment.
It would be great to see a test for this function
There was a problem hiding this comment.
I have a test for the whole process. Will later add the test case!
trigaten
reviewed
Oct 21, 2022
trigaten
reviewed
Oct 21, 2022
trigaten
reviewed
Oct 21, 2022
trigaten
reviewed
Oct 21, 2022
trigaten
reviewed
Oct 21, 2022
| return False | ||
|
|
||
| @gen.coroutine | ||
| def get_non_aggressive_order(self, order: str, powers: List[str]): |
There was a problem hiding this comment.
Would also like to see a test for this function
There was a problem hiding this comment.
that can be added too.
trigaten
reviewed
Oct 21, 2022
trigaten
reviewed
Oct 21, 2022
trigaten
reviewed
Oct 21, 2022
| if not len(ally): | ||
| return | ||
| final_orders = [] | ||
| for order in self.orders.get_list_of_orders(): |
trigaten
reviewed
Oct 21, 2022
| self.orders = orders_data | ||
|
|
||
| # filter out aggressive orders to allies | ||
| yield self.replace_aggressive_order_to_allies() |
There was a problem hiding this comment.
I would highly prefer a pattern in which orders are passed into and out of this function, e.g.
orders = yield self.replace_aggressive_order_to_allies(best_orders)
|
Resolves #91 |
kartik2112
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #92 but still have to add enemy move filter. I want to pull the ally move filter first