Skip to content

fix: task status 완료 시 완료 날짜 업데이트 수정 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chsubinn merged 1 commit into from
Apr 21, 2025
Merged

fix: task status 완료 시 완료 날짜 업데이트 수정 #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/com/amcamp/domain/task/domain/Task.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,12 @@ public void updateTaskBasicInfo(TaskBasicInfoUpdateRequest request) {
}

public void updateTaskStatus() {
if (this.taskStatus != TaskStatus.COMPLETED) this.taskStatus = TaskStatus.COMPLETED;
else {
if (this.taskStatus != TaskStatus.COMPLETED) {
this.taskStatus = TaskStatus.COMPLETED;
this.dueDt = LocalDate.now();
} else {
this.taskStatus = TaskStatus.ON_GOING;
this.dueDt = null;
}
}

Expand Down
9 changes: 6 additions & 3 deletions src/test/java/com/amcamp/domain/task/TaskServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ class 태스크_수정_시 {
}

@Test
@Transactional
void 정상적으로_완료된_태스크를_미완료처리한다() {
// given
TaskCreateRequest taskRequest =
Expand All @@ -283,12 +284,14 @@ class 태스크_수정_시 {
.orElseThrow(() -> new CommonException(TaskErrorCode.TASK_NOT_FOUND));

task.assignTask(participant);
task.updateTaskStatus();

// when
// when & then
task.updateTaskStatus();
assertThat(task.getDueDt()).isEqualTo(LocalDate.now());

// then
// when & then
task.updateTaskStatus();
assertThat(task.getDueDt()).isNull();
assertThat(task.getTaskStatus()).isEqualTo(TaskStatus.ON_GOING);
}

Expand Down