Skip to content

Commit

Permalink
Merge pull request seahorce-scidac#237 from hklion/setup_docs_fillbou…
Browse files Browse the repository at this point in the history
…ndary

add a paragraph to ProblemSetup about FillBoundary
  • Loading branch information
hklion authored Jul 24, 2024
2 parents ef5f3cf + ac30859 commit b4025fe
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Docs/sphinx_doc/ProblemSetup.rst
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,5 @@ Each problem setup with a different initial e.g. temperature profile and bathyme
* ``amrvis.defaults`` (for visualization with AMRVis)

The file ``prob.cpp`` contains a number of functions that set the initial temperature profile, as well as surface stress, mixing coefficients, and bathymetry. New problem-specific input parameters can be defined by adding a variable to the ``ProbParm`` class in ``prob.H``, and reading in the value in ``amrex_probinit`` in ``prob.cpp``. See the AMReX documentation on `ParmParse <https://amrex-codes.github.io/amrex/docs_html/Basics.html#parmparse>`_ for how to add parameters.

REMORA will call ``FillBoundary`` on the relevant variables after the functions in ``prob.cpp`` are called. This will fill the values in the `ghost cells <https://amrex-codes.github.io/amrex/docs_html/Basics.html#ghost-cells>`_ at interior grid-grid and periodic boundaries. However, it will not do so at interior grid-grid boundaries that fall on non-periodic domain boundaries. This is primarily a concern for variables such as bathymetry, which are not specified by boundary conditions, but still have well-defined values at boundaries.

0 comments on commit b4025fe

Please sign in to comment.