when we "make" without a "clean", ensure that the same net is used #3073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a common error is to build the executable, do a run, and then change the network by building with NETWORK_DIR set, without a "make clean". This leads to an undefined behavior. This adds a check to ensure that when we make we are using the same network as done originally, and if not, aborts with a message saying to do "make clean"
|
this is a different fix to the same problem identified in #2652 |
yut23
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a common error is to build the executable, do a run, and then change the network by building with NETWORK_DIR set, without a "make clean". This leads to an undefined behavior. This adds a check to ensure that when we make we are using the same network as done originally, and if not, aborts with a message saying to do "make clean"
PR summary
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate