Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate init_species_all_equal in favor of uniform_xn #1736

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

remove duplicate init_species_all_equal in favor of uniform_xn #1736

wants to merge 2 commits into from

Conversation

zingale
Copy link
Member

@zingale zingale commented Feb 6, 2025 •
edited
Loading

test_react had already implemented uniform_xn, so now we bump that runtime parameter up a level so all unit tests can use it.

This also updates eos_cell, burn_cell_sdc, and jac_cell to support this feature.

@zingale
remove duplicate init_species_all_equal in favor of uniform_xn
27b71fc 
test_react had already implemented uniform_xn, so now we bump
that runtime parameter up a level so all unit tests can use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhichen3 zhichen3 zhichen3 approved these changes

Assignees
No one assigned
Labels
cleaning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @zhichen3