Fix includes #4308
Merged
Fix includes #4308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
approved these changes
Jan 22, 2025
|
Ah, small updates still needed in call sites like |
WeiqunZhang
force-pushed
the
fix_include
branch
from
462c351 to
d8a3c97
Compare
We should not include std headers inside amrex namespace.
WeiqunZhang
force-pushed
the
fix_include
branch
from
d8a3c97 to
702a9a6
Compare
|
This could maybe fix it, although we will only truly know after merging this and then trying to build hipace and impactx documentation. |
|
In any case, we need to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not include std headers inside amrex namespace directly or indirectly.