Clarify what "requested_time" should be set to when "activation":"mod… #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e" is set to "activate_immediate" It's unclear what "requested_time" should be set to when "activation":"mode" is set to "activate_immediate". Should it be null or absent or either. The examples show it set to null but absent doesn't seem unreasonable so I've gone with that option. Please amend as required.
peterbrightwell
approved these changes
Mar 26, 2025
peterbrightwell
pushed a commit
that referenced
this pull request
Mar 26, 2025
…e" is set to "activate_immediate" (#175) It's unclear what "requested_time" should be set to when "activation":"mode" is set to "activate_immediate". Should it be null or absent or either. The examples show it set to null but absent doesn't seem unreasonable so I've gone with that option. Please amend as required.
peterbrightwell
added a commit
that referenced
this pull request
Apr 2, 2025
* Fix copy/paste typo as per #169 * Remove duplicate keys from schema defintions (#176) * Clarify what "requested_time" should be set to when "activation":"mode" is set to "activate_immediate" (#175) It's unclear what "requested_time" should be set to when "activation":"mode" is set to "activate_immediate". Should it be null or absent or either. The examples show it set to null but absent doesn't seem unreasonable so I've gone with that option. Please amend as required. * Behaviour: RTCP (#168) * Update Behaviour - RTP Transport Type.md Revised language in ARG call 2025-03-26 --------- Co-authored-by: Peter Brightwell <peter.brightwell@bbc.co.uk> --------- Co-authored-by: Jonas Reucher <JonasReucher@gmail.com> Co-authored-by: Pete-Cordell <pcordell@nevion.com> Co-authored-by: N-Nagorny <15526762+N-Nagorny@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e" is set to "activate_immediate"
It's unclear what "requested_time" should be set to when "activation":"mode" is set to "activate_immediate". Should it be null or absent or either. The examples show it set to null but absent doesn't seem unreasonable so I've gone with that option. Please amend as required.