-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Week2] (#3) 2주차 과제 #4
Open
mnbvcxzyj
wants to merge
28
commits into
main
Choose a base branch
from
feature/#3_week2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,990
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnbvcxzyj
force-pushed
the
feature/#3_week2
branch
from
October 25, 2024 14:33
c30db28
to
560c007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 작업 내용
1) StackView Extension 추가
2) delegate 패턴 구현
3) UIButton Configuration으로 버튼 구현
🙏🏻 To Reviewer
🤔 stackView
여기 부분을 구현할 때,
.fillEqually
값을 주었는데 구분선까지 함께 넓어지면서 제가 생각하는대로 구현되지 않았습니다 .. ^_^ .. ;;그래서
.fillProportionally
와$0.width.equalTo(infoStackView.snp.width).multipliedBy(1.0 / 3.0)
를 작성하여 각 하위 stackView에 3등분으로 너비 값을 지정해주면 그나마 제가 원하는 느낌으로 뷰가 배치되었는데 더 좋은 방법이 있는지 궁금합니다.이외에도 많은 피드백 부탁드립니다.. 감사합니다 ^ __ ^ ..
📸 시연 영상