Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/import updates from forked version #1

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

zgxsin
Copy link

@zgxsin zgxsin commented Jan 20, 2022

This MR imports the updates from the upstream repository

civerachb-cpr and others added 25 commits February 3, 2020 09:53
…correct endpoint & matches the general structure of the pointgrey_camera_driver
* [spinnaker_camera_driver] Fixed naming of frame rate control params

* [spinnaker_camera_driver] Format of mono and stereo launchfiles

* [spinnaker_camera_driver] Updated diagnostics launchfile
* spinnaker_camera_driver: setProperty: report available enum values

Only done on failure. This helps to figure out which enum values are
available on a particular camera model.

* spinnaker_camera_driver: expose AE ROI parameters

This is highly useful when using fisheye lenses, which illuminate only
a circle in the center of the image. The AE gets confused by the black
regions around it and overexposes the image.

This also exposes the "AutoExposureLightingMode" parameter, which allows
the user to choose a lighting preset (front/back/normal).
Fix for correct spelling with capital letter for bool type
* Add horizontal/vertical inverse to reconfigure cfg

* Add ReverseX/ReverseY with setProperty

Co-authored-by: Fabian Schilling <fabian.schilling@me.com>
* fixes error on destroying SpinnakerCamera with multiple cameras

* adds clarifying comment
* Changes required to use GigE Blackfly S version

* Update SpinnakerCamera.cpp
…ers#81)

* Changes required to use GigE Blackfly S version

* Added blackfly mesh

* Added URDF of blackflys and CHANGELOG

* Added new_line at end of flir_blackflys.urdf.xacro

* Added DiagnosticAnalyzers and more detailed diagnostic messages

* Added ISP enable and disable config and updated camera launch file to be more descriptive

* Switched order of configuration to put ISP enable next to color encoding

* Updated config to include enumeration for Off, Once, Continuous parameters, and udpated diagnostics.launch

* Handled issue where no namespace prevents diagnostics_agg from loading from analyzer paramaters
…version

# Conflicts:
#	.travis.yml
#	cfg/Spinnaker.cfg
#	cmake/DownloadSpinnaker.cmake
#	cmake/modules/FindSpinnaker.cmake
#	include/any_spinnaker_camera_driver/SpinnakerCamera.h
#	include/any_spinnaker_camera_driver/diagnostics.h
#	include/any_spinnaker_camera_driver/gh3.h
#	include/any_spinnaker_camera_driver/set_property.h
#	launch/camera.launch
#	launch/diagnostics.launch
#	launch/stereo.launch
#	package.xml
#	spinnaker_camera_driver/CMakeLists.txt
#	src/SpinnakerCamera.cpp
#	src/diagnostics.cpp
#	src/gh3.cpp
#	src/nodelet.cpp
@YoshuaNava
Copy link
Member

Hi @zgxsin,

  1. Can you make a high-level summary of the main changes?
  2. How is the driver's behavior/workflow/robustness/etc expected to change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.