forked from ros-drivers/flir_camera_driver
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/import updates from forked version #1
Open
zgxsin
wants to merge
25
commits into
master
Choose a base branch
from
feature/import_updates_from_forked_version
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correct endpoint & matches the general structure of the pointgrey_camera_driver
Fix Flycap & Spinnaker endpoints
… unpack directory. (ros-drivers#44)
* [spinnaker_camera_driver] Fixed naming of frame rate control params * [spinnaker_camera_driver] Format of mono and stereo launchfiles * [spinnaker_camera_driver] Updated diagnostics launchfile
* spinnaker_camera_driver: setProperty: report available enum values Only done on failure. This helps to figure out which enum values are available on a particular camera model. * spinnaker_camera_driver: expose AE ROI parameters This is highly useful when using fisheye lenses, which illuminate only a circle in the center of the image. The AE gets confused by the black regions around it and overexposes the image. This also exposes the "AutoExposureLightingMode" parameter, which allows the user to choose a lighting preset (front/back/normal).
Fix for correct spelling with capital letter for bool type
* Add horizontal/vertical inverse to reconfigure cfg * Add ReverseX/ReverseY with setProperty Co-authored-by: Fabian Schilling <fabian.schilling@me.com>
…eparate files for clarity. (ros-drivers#26)
* fixes error on destroying SpinnakerCamera with multiple cameras * adds clarifying comment
* Changes required to use GigE Blackfly S version * Update SpinnakerCamera.cpp
…ers#81) * Changes required to use GigE Blackfly S version * Added blackfly mesh * Added URDF of blackflys and CHANGELOG * Added new_line at end of flir_blackflys.urdf.xacro * Added DiagnosticAnalyzers and more detailed diagnostic messages * Added ISP enable and disable config and updated camera launch file to be more descriptive * Switched order of configuration to put ISP enable next to color encoding * Updated config to include enumeration for Off, Once, Continuous parameters, and udpated diagnostics.launch * Handled issue where no namespace prevents diagnostics_agg from loading from analyzer paramaters
…version # Conflicts: # .travis.yml # cfg/Spinnaker.cfg # cmake/DownloadSpinnaker.cmake # cmake/modules/FindSpinnaker.cmake # include/any_spinnaker_camera_driver/SpinnakerCamera.h # include/any_spinnaker_camera_driver/diagnostics.h # include/any_spinnaker_camera_driver/gh3.h # include/any_spinnaker_camera_driver/set_property.h # launch/camera.launch # launch/diagnostics.launch # launch/stereo.launch # package.xml # spinnaker_camera_driver/CMakeLists.txt # src/SpinnakerCamera.cpp # src/diagnostics.cpp # src/gh3.cpp # src/nodelet.cpp
Hi @zgxsin,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR imports the updates from the upstream repository