Skip to content

Conversation

@fmrico
Copy link

@fmrico fmrico commented Dec 3, 2020

Dear all,

This PR contains:

  • Adding pluginlib dependency in CMakeLists.txt and package.xml.
  • Fixes for deprecation in TYPED_TEST_CASE, rosbag API, and rclcppp::Duration constructor.

All these deprecations are with respect to ROS2 main branch.

I hope it helps!

Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
Signed-off-by: Francisco Martin Rico <fmrico@gmail.com>
@SteveMacenski
Copy link

Copy link
Collaborator

@maximilianwulf maximilianwulf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the MR submission.

sensor_msgs
rclcpp
OpenCV
pluginlib
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you for the MR. Pluginlib should be an indirect dependency through the filters package, at least for ROS1. https://github.com/ros/filters/blob/lunar-devel/package.xml

Did you experience compilation issues?

@wep21 wep21 mentioned this pull request Apr 13, 2021
@SteveMacenski
Copy link

#296 supersedes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants