-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary PR to generate a full bikeshed diff compared to v1.1.0 #293
Open
leo-barnes
wants to merge
65
commits into
u/lbarnes/final_review_base
Choose a base branch
from
u/lbarnes/final_review_diff
base: u/lbarnes/final_review_base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Temporary PR to generate a full bikeshed diff compared to v1.1.0 #293
leo-barnes
wants to merge
65
commits into
u/lbarnes/final_review_base
from
u/lbarnes/final_review_diff
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix white spaces, indentation, newlines, missing closing HTML elements and mismatched opening/closing HTML elements.
1. Add lsel property with value 0xFFFF 2. Add NCLX colr box with value 1,13,1,0 (since this matches what the PNGs look like)
Microsoft/Chimera_*_cropped_*.avif: - Truncated crop to integers - Stripped optional config OBUs Link-U/kimono*.crop.avif: - Reordered property associations so 'ispe' comes before transform properties - Rounded up crop to integers (that matches the PNGs) - Added NCLX with values 1,13,9,0 - Stripped optional config OBUs
…70.avif to fix issue 151 Summer_in_Tomsk_720p_5x4_grid.avif: - Added NCLX 1,13,6,0 for all items - Added pixi for grid item - Strip optional config OBUs from av1C Chimera-AV1-10bit-480x270.avif: - Added NCLX 1,13,6,0 - Added pixi - Strip optional config OBUs from av1C - Set track_in_movie to true for track
Changes done: 1. Change order of item property associations to place ispe first 2. Add colr-nclx box with values 1,13,9,0 since this is what Sequence Header says 3. Strip out optional config OBUs from av1C
Also fix crash in sanitizer for some profile 2 files testFiles/Link-U/hato.profile0.10bpc.yuv420.monochrome.no-cdef.no-restoration.avif testFiles/Link-U/hato.profile0.8bpc.yuv420.monochrome.no-cdef.avif testFiles/Link-U/hato.profile2.10bpc.yuv422.monochrome.no-cdef.no-restoration.avif testFiles/Link-U/hato.profile2.8bpc.yuv422.monochrome.no-cdef.avif Remove optional config OBUs Insert default colr box Fix incorrect pixi testFiles/Link-U/fox.profile2.10bpc.yuv422.avif testFiles/Link-U/fox.profile2.10bpc.yuv422.odd-height.avif testFiles/Link-U/fox.profile2.10bpc.yuv422.odd-width.avif testFiles/Link-U/fox.profile2.10bpc.yuv422.odd-width.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv422.avif testFiles/Link-U/fox.profile2.12bpc.yuv422.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv422.odd-width.avif testFiles/Link-U/fox.profile2.12bpc.yuv422.odd-width.odd-height.avif testFiles/Link-U/hato.profile2.10bpc.yuv422.no-cdef.no-restoration.avif testFiles/Link-U/hato.profile2.12bpc.yuv422.monochrome.no-cdef.no-restoration.avif testFiles/Link-U/hato.profile2.12bpc.yuv422.no-cdef.no-restoration.avif testFiles/Link-U/fox.profile2.8bpc.yuv422.avif testFiles/Link-U/fox.profile2.8bpc.yuv422.odd-height.avif testFiles/Link-U/fox.profile2.8bpc.yuv422.odd-width.avif testFiles/Link-U/fox.profile2.8bpc.yuv422.odd-width.odd-height.avif Update av1C: av1C[chroma_subsampling_x] does not match Sequence Header OBU. '0' != '1' Remove optional config OBUs Insert default colr box testFiles/Link-U/fox.profile0.10bpc.yuv420.avif testFiles/Link-U/fox.profile0.10bpc.yuv420.monochrome.avif testFiles/Link-U/fox.profile0.10bpc.yuv420.monochrome.odd-height.avif testFiles/Link-U/fox.profile0.10bpc.yuv420.monochrome.odd-width.avif testFiles/Link-U/fox.profile0.10bpc.yuv420.monochrome.odd-width.odd-height.avif testFiles/Link-U/fox.profile0.10bpc.yuv420.odd-height.avif testFiles/Link-U/fox.profile0.10bpc.yuv420.odd-width.avif testFiles/Link-U/fox.profile0.10bpc.yuv420.odd-width.odd-height.avif testFiles/Link-U/fox.profile0.8bpc.yuv420.avif testFiles/Link-U/fox.profile0.8bpc.yuv420.monochrome.avif testFiles/Link-U/fox.profile0.8bpc.yuv420.monochrome.odd-height.avif testFiles/Link-U/fox.profile0.8bpc.yuv420.monochrome.odd-width.avif testFiles/Link-U/fox.profile0.8bpc.yuv420.monochrome.odd-width.odd-height.avif testFiles/Link-U/fox.profile0.8bpc.yuv420.odd-height.avif testFiles/Link-U/fox.profile0.8bpc.yuv420.odd-width.avif testFiles/Link-U/fox.profile0.8bpc.yuv420.odd-width.odd-height.avif testFiles/Link-U/fox.profile1.10bpc.yuv444.avif testFiles/Link-U/fox.profile1.10bpc.yuv444.odd-height.avif testFiles/Link-U/fox.profile1.10bpc.yuv444.odd-width.avif testFiles/Link-U/fox.profile1.10bpc.yuv444.odd-width.odd-height.avif testFiles/Link-U/fox.profile1.8bpc.yuv444.avif testFiles/Link-U/fox.profile1.8bpc.yuv444.odd-height.avif testFiles/Link-U/fox.profile1.8bpc.yuv444.odd-width.avif testFiles/Link-U/fox.profile1.8bpc.yuv444.odd-width.odd-height.avif testFiles/Link-U/fox.profile2.10bpc.yuv422.avif testFiles/Link-U/fox.profile2.10bpc.yuv422.monochrome.avif testFiles/Link-U/fox.profile2.10bpc.yuv422.monochrome.odd-height.avif testFiles/Link-U/fox.profile2.10bpc.yuv422.monochrome.odd-width.avif testFiles/Link-U/fox.profile2.10bpc.yuv422.monochrome.odd-width.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv420.avif testFiles/Link-U/fox.profile2.12bpc.yuv420.monochrome.avif testFiles/Link-U/fox.profile2.12bpc.yuv420.monochrome.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv420.monochrome.odd-width.avif testFiles/Link-U/fox.profile2.12bpc.yuv420.monochrome.odd-width.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv420.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv420.odd-width.avif testFiles/Link-U/fox.profile2.12bpc.yuv420.odd-width.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv422.monochrome.avif testFiles/Link-U/fox.profile2.12bpc.yuv422.monochrome.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv422.monochrome.odd-width.avif testFiles/Link-U/fox.profile2.12bpc.yuv422.monochrome.odd-width.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv444.avif testFiles/Link-U/fox.profile2.12bpc.yuv444.monochrome.avif testFiles/Link-U/fox.profile2.12bpc.yuv444.monochrome.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv444.monochrome.odd-width.avif testFiles/Link-U/fox.profile2.12bpc.yuv444.monochrome.odd-width.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv444.odd-height.avif testFiles/Link-U/fox.profile2.12bpc.yuv444.odd-width.avif testFiles/Link-U/fox.profile2.12bpc.yuv444.odd-width.odd-height.avif testFiles/Link-U/fox.profile2.8bpc.yuv422.monochrome.avif testFiles/Link-U/fox.profile2.8bpc.yuv422.monochrome.odd-height.avif testFiles/Link-U/fox.profile2.8bpc.yuv422.monochrome.odd-width.avif testFiles/Link-U/fox.profile2.8bpc.yuv422.monochrome.odd-width.odd-height.avif testFiles/Link-U/hato.profile0.10bpc.yuv420.no-cdef.no-restoration.avif testFiles/Link-U/hato.profile0.8bpc.yuv420.no-cdef.avif testFiles/Link-U/hato.profile2.12bpc.yuv422.monochrome.avif Remove optional config OBUs Insert default colr box
This closes #182
Add tmap and altr text
Introduce Sample Transform Derived Image Items in AVIF. Add the Definition, Syntax, Semantics and Constraints sections.
Make it obvious that AVIF also supports 16-bit.
Increase unary operator range to 64+ to leave room for more operand token types.
Clarify that non-essential item properties may use other versions. This closes #247.
along other supported features.
Moved box type definition anchors to the root spec listed in table of boxes Added links to all box types in table of boxes Sorted all anchors, removed duplicates Removed duplicated lists of boxes
To make sure the first sentence of each derived image item section is rendered in a similar way.
Same as for Operating Point Selector Property sections.
Use box names instead of some property 4CC types. Add a comment about creating the stack in the Syntax section.
- Change optional boxes table to have same layering as required boxes table. - Change text on box order - Change text on `dinf`
Section 9.1 also applies to an AVIF file containing image items and image sequences, so remove "only" from "containing only image items".
Otherwise, it seems that it is the specifications that shall be respected. Also make the second instance of this sentence more similar to the first instance.
The 'colr' box specifies color information.
In prevision of the major_brand field of the FileTypeBox not needing to be repeated in the compatible_brands field.
Fix use of br tags in SATO examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there's no documented way of generating the "diff" document yourself, so this temporary PR will serve as the generator for it.
This is the v1.2.0 release candidate diff against v1.1.0.
Preview | Diff