Skip to content

Commit

Permalink
Address some concerns in AOMediaCodec/libiamf#114.
Browse files Browse the repository at this point in the history
  - `test_000123`: Fix editorial typo
 from AOMediaCodec/libiamf#114 (comment).
  - `test_000098`: Address AOMediaCodec/libiamf#114 (comment).
    - Configure to pass through the Opus float API, but still configure it to generate a 16-bit file for output comparison file.

PiperOrigin-RevId: 657332276
  • Loading branch information
jwcullen committed Jul 29, 2024
1 parent 3a7cefa commit 3363a86
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions iamf/cli/testdata/test_000098.textproto
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@

test_vector_metadata {
human_readable_description:
"A 2-layer IAMF stream encoded using Opus with the last layer "
"being 5.1 and a 32-bit input wav file."
"A 2-layer IAMF stream encoded by normalizing the input 32-bit wav file to "
"the range [-1.0, 1.0] then encoding it with the Opus float API."
file_name_prefix: "test_000098"
is_valid: true
validate_user_loudness: true
Expand All @@ -29,6 +29,7 @@ test_vector_metadata {
"3.11.1/OPUS Specific"
]
base_test: "test_000049"
output_wav_file_bit_depth_override: 16
}

ia_sequence_header_metadata {
Expand All @@ -49,7 +50,7 @@ codec_config_metadata {
opus_encoder_metadata {
target_bitrate_per_channel: 48000
application: APPLICATION_AUDIO
use_float_api: false
use_float_api: true
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions iamf/cli/testdata/test_000123.textproto
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ test_vector_metadata {
human_readable_description:
"A 7.1.4 + TOA IAMF stream encoded using Opus and with two Mix "
"Presentations. The first Mix Presentation uses both Audio Elements. The "
"second Mix Presentation uses only the 7.1.4 Audio Element. The primary "
"second Mix Presentation uses only the TOA Audio Element. The primary "
"profile is set to Base and the additional profile is set to "
" Base-Enhanced."
"Base-Enhanced."
file_name_prefix: "test_000123"
is_valid: true
validate_user_loudness: true
Expand Down

0 comments on commit 3363a86

Please sign in to comment.