-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix a bug that forbid temporal delimiters from base-enhanced profile.
- `test_000712`: `Base-enhanced` profile with temporal delimiter OBUs.
- Would have failed in the past, and useful in the public suite, to clarify they are permitted in base-enhanced profile as well.
- Update language in a sister test case, because it refers to the incorrect section number.
- Remove useless abstraction that temporal delimiters can be forbidden:
- In an older draft of the spec, some profiles forbid temporal delimiters.
- In the modern drafts of the spec, they are always permitted.
- The spec does not imply or promise any rules or conditions on when they would be forbidden in future versions.
- The abstraction is useless under these conditions. And it would belong in `ProfileFilter` in the modern codebase.
- Note: Since "Base-enhanced" was omitted from
a table in `ProfileSupportsTemporalDelimiterObus`, now the code permits them.
- b/302470464: Increase coverage of temporal delimiters.
PiperOrigin-RevId: 691004564- Loading branch information
Showing
10 changed files
with
291 additions
and
156 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| # Copyright (c) 2024, Alliance for Open Media. All rights reserved | ||
| # | ||
| # This source code is subject to the terms of the BSD 3-Clause Clear License | ||
| # and the Alliance for Open Media Patent License 1.0. If the BSD 3-Clause Clear | ||
| # License was not distributed with this source code in the LICENSE file, you | ||
| # can obtain it at www.aomedia.org/license/software-license/bsd-3-c-c. If the | ||
| # Alliance for Open Media Patent License 1.0 was not distributed with this | ||
| # source code in the PATENTS file, you can obtain it at | ||
| # www.aomedia.org/license/patent. | ||
|
|
||
| # proto-file: iamf/cli/proto/user_metadata.proto | ||
| # proto-message: UserMetadata | ||
|
|
||
| test_vector_metadata { | ||
| human_readable_description: | ||
| "A Base-Enhanced IAMF stream with Temporal Delimiter" | ||
| " OBUs " | ||
| file_name_prefix: "test_000712" | ||
| is_valid: true | ||
| is_valid_to_decode: true | ||
| validate_user_loudness: true | ||
| mp4_fixed_timestamp: "2024-10-28 00:00:00" | ||
| test_repository_tags: [ | ||
| "github/aomediacodec/libiamf/main" | ||
| ] | ||
| primary_tested_spec_sections: ["3.10/Temporal Delimiter OBU"] | ||
| base_test: "test_000005" | ||
| } | ||
|
|
||
| ia_sequence_header_metadata { | ||
| primary_profile: PROFILE_VERSION_BASE_ENHANCED | ||
| additional_profile: PROFILE_VERSION_BASE_ENHANCED | ||
| } | ||
|
|
||
| codec_config_metadata { | ||
| codec_config_id: 200 | ||
| codec_config { | ||
| codec_id: CODEC_ID_LPCM | ||
| num_samples_per_frame: 64 | ||
| audio_roll_distance: 0 | ||
| decoder_config_lpcm { | ||
| sample_format_flags: LPCM_LITTLE_ENDIAN | ||
| sample_size: 16 | ||
| sample_rate: 16000 | ||
| } | ||
| } | ||
| } | ||
|
|
||
| audio_element_metadata { | ||
| audio_element_id: 300 | ||
| audio_element_type: AUDIO_ELEMENT_CHANNEL_BASED | ||
| reserved: 0 | ||
| codec_config_id: 200 | ||
| num_substreams: 1 | ||
| audio_substream_ids: [0] | ||
| num_parameters: 0 | ||
| scalable_channel_layout_config { | ||
| num_layers: 1 | ||
| reserved: 0 | ||
| channel_audio_layer_configs: [ | ||
| { | ||
| loudspeaker_layout: LOUDSPEAKER_LAYOUT_EXPANDED | ||
| expanded_loudspeaker_layout: EXPANDED_LOUDSPEAKER_LAYOUT_STEREO_S | ||
| output_gain_is_present_flag: 0 | ||
| recon_gain_is_present_flag: 0 | ||
| reserved_a: 0 | ||
| substream_count: 1 | ||
| coupled_substream_count: 1 | ||
| } | ||
| ] | ||
| } | ||
| } | ||
|
|
||
| mix_presentation_metadata { | ||
| mix_presentation_id: 42 | ||
| count_label: 1 | ||
| annotations_language: ["en-us"] | ||
| localized_presentation_annotations: ["test_mix_pres"] | ||
| num_sub_mixes: 1 | ||
| sub_mixes { | ||
| num_audio_elements: 1 | ||
| audio_elements { | ||
| audio_element_id: 300 | ||
| localized_element_annotations: ["test_sub_mix_0_audio_element_0"] | ||
| rendering_config { | ||
| headphones_rendering_mode: HEADPHONES_RENDERING_MODE_STEREO | ||
| } | ||
| element_mix_gain { | ||
| param_definition { | ||
| parameter_id: 100 | ||
| parameter_rate: 16000 | ||
| param_definition_mode: 1 | ||
| reserved: 0 | ||
| } | ||
| default_mix_gain: 0 | ||
| } | ||
| } | ||
| output_mix_gain { | ||
| param_definition { | ||
| parameter_id: 100 | ||
| parameter_rate: 16000 | ||
| param_definition_mode: 1 | ||
| reserved: 0 | ||
| } | ||
| default_mix_gain: 0 | ||
| } | ||
| num_layouts: 1 | ||
| layouts { | ||
| loudness_layout { | ||
| layout_type: LAYOUT_TYPE_LOUDSPEAKERS_SS_CONVENTION | ||
| ss_layout { | ||
| sound_system: SOUND_SYSTEM_A_0_2_0 | ||
| reserved: 0 | ||
| } | ||
| } | ||
| loudness { | ||
| info_type_bit_masks: [] | ||
| integrated_loudness: -13733 | ||
| digital_peak: -12879 | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| audio_frame_metadata { | ||
| wav_filename: "sawtooth_100_stereo.wav" | ||
| samples_to_trim_at_end: 0 | ||
| samples_to_trim_at_start: 0 | ||
| audio_element_id: 300 | ||
| channel_metadatas: [ | ||
| { channel_id: 0 channel_label: CHANNEL_LABEL_LS_5 }, | ||
| { channel_id: 1 channel_label: CHANNEL_LABEL_RS_5 } | ||
| ] | ||
| } | ||
| parameter_block_metadata { | ||
| parameter_id: 100 | ||
| start_timestamp: 0 | ||
| duration: 8000 | ||
| num_subblocks: 1 | ||
| constant_subblock_duration: 8000 | ||
| subblocks: [ | ||
| { | ||
| mix_gain_parameter_data { | ||
| animation_type: ANIMATE_STEP | ||
| param_data { | ||
| step { | ||
| start_point_value: 0 | ||
| } | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| temporal_delimiter_metadata { | ||
| enable_temporal_delimiters: true | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.