Enable FLAC support on Windows.

  - Informational source:
    - See `copts`, `defines`, and `local_defines` at https://bazel.build/reference/be/c-cpp#cc_library for informational purposes.
  - Primary change:
    - Move `FLAC__NO_DLL` from `copts` to `defines` which are propagated to all users of the library.
    - This propagates to `iamf_tools/iamf/cli:flac_encoder` which allows it to link correctly.
  - Drive-by changes:
    - Move other FLAC defines from `copts` to `local_defines` which is preferred.
    - Enable `flac_encoder` tests on Windows GitHub CI now that this component works correctly.
    - Adjust some `linkopts` and `defines` which are not needed on all platforms.
    - Remove obsolete `flac_encoder_windows.cc` which was only useful to provide stubs.

PiperOrigin-RevId: 671855541

.github/actions/iamf-tools-builder/action.yml

@@ -17,7 +17,7 @@ runs:
           # Windows works best with a very short path as per https://bazel.build/configure/windows#long-path-issues.
           echo  "startup --output_user_root=C:/" >> .bazelrc
           # Disable some windows tests until some platform-specific bugs are fixed.
-          TEST_FILTER=*:-FlacEncoder*:*TestVector.ValidateTestSuite*:EncoderMainLibTest.*
+          TEST_FILTER=*:-*TestVector.ValidateTestSuite*:EncoderMainLibTest.*
         else
           TEST_FILTER=*
         fi

external/flac.BUILD

@@ -47,26 +47,39 @@ flac_hdrs = glob([
 
 flac_copts = [
     "-w",
-    "-DFLAC__USE_VISIBILITY_ATTR",
-    "-DPACKAGE_VERSION=\\\"1.4.3\\\"",
-    "-DHAVE_STDINT_H",
-    "-DHAVE_LROUND",
-    "-DNDEBUG",
-    "-D_FORTIFY_SOURCE=2",
-    "-DFLAC__HAS_OGG=0",
-    "-DFLAC__NO_DLL",  # Static library for Windows
     "-Iexternal/flac/src/libFLAC/include",
     "-Iexternal/flac/include",
 ]
 
-flac_linkopts = ["-lm"]
+flac_local_defines = [
+    "FLAC__HAS_OGG=0",
+    "FLAC__USE_VISIBILITY_ATTR",
+    "PACKAGE_VERSION=\\\"1.4.3\\\"",
+    "HAVE_STDINT_H",
+    "HAVE_LROUND",
+    "NDEBUG",
+    "_FORTIFY_SOURCE=2",
+]
+
+# Defines which need to propagate to all downstream users.
+flac_defines = [
+    "@platforms//os:windows": ["FLAC__NO_DLL"],
+    "//conditions:default": [],
+]
+
+flac_linkopts = select({
+    "@platforms//os:windows": [],
+    "//conditions:default": ["-lm"],
+})
 
 cc_library(
     name = "flac",
     srcs = flac_srcs,
     hdrs = flac_hdrs,
     copts = flac_copts,
+    defines = flac_defines,
     linkopts = flac_linkopts,
+    local_defines = flac_local_defines,
     textual_hdrs = flac_textual_includes,
 )
 

iamf/cli/codec/BUILD

@@ -74,15 +74,9 @@ cc_library(
     ],
 )
 
-# TODO(b/362229054): Enable FLAC support on Windows and unify `flac_encoder.cc` and
-#                    `flac_encoder_windows.cc`.
-
 cc_library(
     name = "flac_encoder",
-    srcs = select({
-        "@platforms//os:windows": ["flac_encoder_windows.cc"],
-        "//conditions:default": ["flac_encoder.cc"],
-    }),
+    srcs = ["flac_encoder.cc"],
     hdrs = ["flac_encoder.h"],
     deps = [
         ":encoder_base",