Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial CM1 P3 results with fixed droplets and diagnostic ice #55

Merged
merged 13 commits into from
May 20, 2024
Merged

Initial CM1 P3 results with fixed droplets and diagnostic ice #55

merged 13 commits into from
May 20, 2024

Conversation

kkchandr
Copy link
Collaborator

No description provided.

twjuliano
twjuliano reviewed Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@twjuliano twjuliano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkchandr Are the two files pushed to 'sandbox' the same as those in 'devel'? If so, let's keep them in just 'sandbox', as we're asking folks to use 'devel' for perturbed runs rather than the requested runs. Thanks.

notebooks/plotting/check_les.ipynb Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkchandr Please remove this file from the commit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twjuliano I revert the commit.

notebooks/conversion/convert_comble_dephy_forcing_to_DHARMA_LES_and_ModelE3_SCM_forcing.ipynb Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kkchandr Does this file contain adapted code to convert the DEPHY forcing to forcing for CM1? If so, please rename the file to something like 'convert_comble_dephy_forcing_to_CM1_LES_forcing.ipynb' so that we don't overwrite the original file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@twjuliano It doesn't contain any modification for the CM1 forcing. I reverted this commit.

@twjuliano twjuliano self-assigned this Apr 16, 2024
twjuliano
twjuliano reviewed May 15, 2024
View reviewed changes
output_les/cm1-p3/devel/CM1-P3_Lx25_dx100_FixN_noice.nc Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file name is the same as the one in the 'sandbox' folder. Can you confirm that this is a duplicate and then remove?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed these files.

@twjuliano
Copy link
Collaborator

@kkchandr looks good, thanks!

@twjuliano twjuliano merged commit 9934cf5 into main May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twjuliano twjuliano twjuliano approved these changes

Assignees

@twjuliano twjuliano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkchandr @twjuliano